Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct the behavior to defer closeSegmentIndex() calls during updates #7217

Merged
merged 5 commits into from
Aug 28, 2024
Merged

fix: Correct the behavior to defer closeSegmentIndex() calls during updates #7217

merged 5 commits into from
Aug 28, 2024

Conversation

JulianDomingo
Copy link
Contributor

@JulianDomingo JulianDomingo commented Aug 27, 2024 •
edited
Loading

Resolves the issues reported by #7213, which correctly fixes #7156.

The latest comment #7156 (comment) goes further into detail on the problems of the initial PR.

@JulianDomingo JulianDomingo self-assigned this Aug 27, 2024
@JulianDomingo JulianDomingo added priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format platform: Cast Issues affecting Cast devices labels Aug 27, 2024
@JulianDomingo JulianDomingo marked this pull request as ready for review August 27, 2024 08:10
@avelad avelad added this to the v4.11 milestone Aug 27, 2024
@avelad
Copy link
Member

avelad commented Aug 27, 2024

@JulianDomingo please fix lint errors. Thanks!

@avelad
Copy link
Member

avelad commented Aug 27, 2024

I'm trying your change but I still see the errors for which we reverted the previous PR:

imagen

Stream used to test it: https://d24rwxnt7vw9qb.cloudfront.net/v1/dash/e6d234965645b411ad572802b6c9d5a10799c9c1/All_Reference_Streams/4577dca5f8a44756875ab5cc913cd1f1/index.mpd

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@JulianDomingo
Copy link
Contributor Author

JulianDomingo commented Aug 27, 2024 •
edited
Loading

Thanks, Alvaro - are you still seeing buffering/freezing accompanied with those errors using my new change?

I ask because the cannot find segment endTime errors still show up even without my changes (on v4.10.12), but regardless the stream plays smoothly:
Screenshot 2024-08-27 at 12 43 36 PM

Also, maybe I'm not seeing the option for this, but how are you able to customize the Shaka build being used on the Shaka Player demo website?

I wonder if another approach for this fix is to limit this to Cast platform devices only.

@avelad
Copy link
Member

avelad commented Aug 27, 2024

Yes the playback is smooth. The warning is due to #7184

@JulianDomingo JulianDomingo merged commit 7ba7e61 into shaka-project:main Aug 28, 2024
13 of 15 checks passed
@shaka-bot shaka-bot mentioned this pull request Aug 28, 2024
Merged
JulianDomingo added a commit to JulianDomingo/shaka-player that referenced this pull request Aug 28, 2024
@JulianDomingo
fix: Correct the behavior to defer closeSegmentIndex() calls during u…
6b15c46 
…pdates (shaka-project#7217)

Resolves the issues reported by
shaka-project#7213, which correctly
fixes shaka-project#7156.

The latest comment
shaka-project#7156 (comment)
goes further into detail on the problems of the initial PR.
avelad pushed a commit that referenced this pull request Aug 29, 2024
@JulianDomingo @avelad
fix: Correct the behavior to defer closeSegmentIndex() calls during u…
b9005b3 
…pdates (#7217)

Resolves the issues reported by
#7213, which correctly
fixes #7156.

The latest comment
#7156 (comment)
goes further into detail on the problems of the initial PR.
@shaka-bot shaka-bot mentioned this pull request Aug 29, 2024
Merged
avelad pushed a commit that referenced this pull request Aug 29, 2024
@JulianDomingo @avelad
fix: Correct the behavior to defer closeSegmentIndex() calls during u…
af80b87 
…pdates (#7217)

Resolves the issues reported by
#7213, which correctly
fixes #7156.

The latest comment
#7156 (comment)
goes further into detail on the problems of the initial PR.
@shaka-bot shaka-bot mentioned this pull request Aug 29, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 27, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

@tykus160 tykus160 Awaiting requested review from tykus160

Assignees

@JulianDomingo JulianDomingo

Labels
component: DASH The issue involves the MPEG DASH manifest format platform: Cast Issues affecting Cast devices priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
v4.11
3 participants
@JulianDomingo @avelad @shaka-bot