We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is a hidden optional 3rd argument to createPortal Slinky forgot to include:
facebook/react#12247 (comment)
Totally undocumented and doesn't matter until you hit the edge case discussed in there :)
Should be:
@js.native @JSImport("react-dom", JSImport.Namespace, "ReactDOM") object ReactDOM extends js.Object { def render(component: ReactElement, target: Element): ReactInstance = js.native def hydrate(component: ReactElement, target: Element): ReactInstance = js.native def findDOMNode(instance: React.Component): Element = js.native def unmountComponentAtNode(container: Element): Unit = js.native def createPortal(child: ReactElement, container: Element, key: js.UndefOr[String] = js.undefined): ReactElement = js.native }
The text was updated successfully, but these errors were encountered:
Support the key parameter in createPortal
key
createPortal
bd3211f
Fixes #568
d0e5d5a
Support the key parameter in createPortal (#594)
a772ee1
* Support the `key` parameter in `createPortal` Fixes #568 * Run scalafmt * No longer using Netlify
Successfully merging a pull request may close this issue.
There is a hidden optional 3rd argument to createPortal Slinky forgot to include:
facebook/react#12247 (comment)
Totally undocumented and doesn't matter until you hit the edge case discussed in there :)
Should be:
The text was updated successfully, but these errors were encountered: