Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update past yanked crate. #27788

Merged
merged 1 commit into from
Nov 22, 2020
Merged

Update past yanked crate. #27788

merged 1 commit into from
Nov 22, 2020

Conversation

jdm
Copy link
Member

@jdm jdm commented Nov 21, 2020

crossbeam-channel 0.4.3 was yanked in October and 0.4.4 includes crossbeam-rs/crossbeam#533.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 21, 2020
@jdm
Copy link
Member Author

jdm commented Nov 21, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit d8d342b has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 21, 2020
@bors-servo
Copy link
Contributor

⌛ Testing commit d8d342b with merge deee433...

bors-servo added a commit that referenced this pull request Nov 21, 2020
Update past yanked crate.

crossbeam-channel 0.4.3 was yanked in October and 0.4.4 includes crossbeam-rs/crossbeam#533.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 21, 2020
@jdm
Copy link
Member Author

jdm commented Nov 21, 2020

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit d8d342b with merge 66616c6...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 22, 2020
@bors-servo
Copy link
Contributor

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 66616c6 to master...

@bors-servo bors-servo merged commit 66616c6 into servo:master Nov 22, 2020
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants