Make the port of Origin be an Option<u16>
#989
Conversation
The URL specification changed in 2016 [1] [2] such that now the origin's port should be the same as the URL's port. This means that the port can `None` in the case that it is the default port for a scheme. 1. whatwg/url@b0e4def 2. whatwg/html#870 Fixes #821.
|
Is this not a breaking change? |
Yes, I think it is. I've tried to add the breaking change label. |
|
oh, duh. didn't notice that. The change itself seems good, I imagine we have to leave this PR open until we're ready to make breaking changes again? |
|
Any word on when a major release will happen in order to merge this one? |
|
I think we just did a major release, so not soon? |
|
What's the process on making sure this change makes it into the next release if it looks okay to the reviewers here? |
|
I don't believe there is one, the URL crate does breaking changes extremely rarely, and when that happens people will probably go through the issue tracker and find breakages to batch together. We could add a "breaking" label. Perhaps there's a way to make this change non breaking? |
The URL specification changed in 2016 1 2 such that now the origin's port
should be the same as the URL's port. This means that the port can
Nonein the case that it is the default port for a scheme.Fixes #821.
Footnotes
https://github.com/whatwg/url/commit/b0e4def5b62e0be2d75b4b7b5720a5e0ea879596 ↩
https://github.com/whatwg/html/pull/870 ↩