Update SpiderMonkey #494
Update SpiderMonkey #494
Conversation
nox
force-pushed
the
smup
branch
19 times, most recently
from
f8235de to
3f1feac
Compare
nox
force-pushed
the
smup
branch
4 times, most recently
from
011f38b to
2ec45c6
Compare
|
The |
|
Even better, this does not build on Windows with |
|
Error seems to be rust-lang/libc#1433 |
nox
force-pushed
the
smup
branch
2 times, most recently
from
95b07b4 to
9ba26ab
Compare
nox
force-pushed
the
smup
branch
4 times, most recently
from
dd3bffe to
cc0a7b1
Compare
|
I fixed the failing |
nox
force-pushed
the
smup
branch
2 times, most recently
from
1b8107d to
a44a2de
Compare
This comment has been minimized.
This comment has been minimized.
nox
force-pushed
the
smup
branch
12 times, most recently
from
b27943c to
30ac54c
Compare
|
|
||
| VCVARSALL_PATH: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build | ||
|
|
||
| matrix: | ||
| - TARGET: i686-pc-windows-msvc | ||
| CROSS_COMPILE: 1 | ||
| - TARGET: x86_64-pc-windows-msvc | ||
| - TARGET: x86_64-pc-windows-msvc |
There was a problem hiding this comment.
Should we add some UWP targets too?
There was a problem hiding this comment.
Can't without using something like xargo to also build the standard library, sadly.
| ownsUnits_: false, | ||
| _phantom_0: std::marker::PhantomData, | ||
| }; | ||
| if !Evaluate2(self.cx(), options.ptr, &mut source, rval.into()) { |
There was a problem hiding this comment.
We don't need the Utf marker any more?
There was a problem hiding this comment.
source is a root::JS::SourceText<root::mozilla::Utf8Unit>, Evaluate2 only understands UTF-8.
| } else { | ||
| (script.as_bytes().as_ptr(), script.len() as c_uint) | ||
| }; | ||
| assert!(!ptr.is_null()); |
There was a problem hiding this comment.
It got over its dislike of null?
There was a problem hiding this comment.
Empty slices have not been the null pointer for years.
There was a problem hiding this comment.
And strings etc I mean, an &str with a null pointer is UB and has been for many years.
|
@bors-servo r=asajeffrey |
|
📌 Commit a09ebb1 has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
No description provided.