Support (de-)serializing flattened unit struct #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
reviewed
Aug 15, 2024
Comment on lines
+1818
to
+1819
| #[test] | ||
| fn test_flatten_unit_struct() { |
There was a problem hiding this comment.
It would be great if new flatten tests were added to the flatten module in the end of this file. Just my opinion
dtolnay
approved these changes
Aug 15, 2024
@dtolnay , great to hear that. What about moving other connected tests to made them located near to each other? #2788 does that for internally tagged enum tests and I working on similar PR for adjacently tagged enum tests. |
Merged
|
Sure thing! I also tried to trim the names down to avoid as much stuttering now that they're under the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2801.