Oops, fix skip_to_escape on BE architectures #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
approved these changes
Aug 11, 2024
There was a problem hiding this comment.
Thanks!
We could add CI coverage for some other architectures, using Miri. There is an example here:
https://github.com/dtolnay/semver/blob/1.0.23/.github/workflows/ci.yml#L103-L110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have belatedly realized that using
leading_zerosdoes not, in fact, work on big-endian machines. I have updated the test to trigger the failure (reproduce withcargo miri test --test test --target powerpc64-unknown-linux-gnu test_control_character_search) and switched to the slower-but-correctfrom_le_bytesmethod instead.