Check if the coin is zero, not positive

sentinel-official · Aug 8, 2023 · d733409 · d733409
1 parent be2c8ef
commit d733409
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/x/node/keeper/alias.go b/x/node/keeper/alias.go
@@ -8,7 +8,7 @@ import (
 )
 
 func (k *Keeper) FundCommunityPool(ctx sdk.Context, fromAddr sdk.AccAddress, coin sdk.Coin) error {
-	if !coin.IsPositive() {
+	if coin.IsZero() {
 		return nil
 	}
 

diff --git a/x/provider/keeper/alias.go b/x/provider/keeper/alias.go
@@ -5,7 +5,7 @@ import (
 )
 
 func (k *Keeper) FundCommunityPool(ctx sdk.Context, fromAddr sdk.AccAddress, coin sdk.Coin) error {
-	if !coin.IsPositive() {
+	if coin.IsZero() {
 		return nil
 	}
 

diff --git a/x/subscription/keeper/hooks.go b/x/subscription/keeper/hooks.go
@@ -32,7 +32,6 @@ func (k *Keeper) SessionInactiveHook(ctx sdk.Context, id uint64, accAddr sdk.Acc
 
 	var (
 		gigabytePrice  sdk.Coin        // Gigabyte price based on the deposit amount and gigabytes (for NodeSubscription).
-		currentAmount  = sdk.ZeroInt() // Amount to be paid for the current utilization (for NodeSubscription).
 		previousAmount = sdk.ZeroInt() // Amount paid for previous utilization (for NodeSubscription).
 	)
 
@@ -57,10 +56,9 @@ func (k *Keeper) SessionInactiveHook(ctx sdk.Context, id uint64, accAddr sdk.Acc
 
 	// Based on the subscription type (NodeSubscription), calculate the current payment amount.
 	if s, ok := subscription.(*types.NodeSubscription); ok && s.Gigabytes != 0 {
-		currentAmount = hubutils.AmountForBytes(gigabytePrice.Amount, alloc.UtilisedBytes)
-
 		// Calculate the payment to be made for the current utilization.
 		var (
+			currentAmount = hubutils.AmountForBytes(gigabytePrice.Amount, alloc.UtilisedBytes)
 			payment       = sdk.NewCoin(gigabytePrice.Denom, currentAmount.Sub(previousAmount))
 			stakingShare  = k.node.StakingShare(ctx)
 			stakingReward = hubutils.GetProportionOfCoin(payment, stakingShare)