Merge pull request #164

Added additional condition for update quota
sentinel-official · Mar 13, 2022 · 7001dc8 · 7001dc8
2 parents f1831f0 + 8c9465a
commit 7001dc8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/x/subscription/keeper/msg_server.go b/x/subscription/keeper/msg_server.go
@@ -283,6 +283,9 @@ func (k *msgServer) MsgUpdateQuota(c context.Context, msg *types.MsgUpdateQuotaR
 	if !found {
 		return nil, types.ErrorSubscriptionDoesNotExist
 	}
+	if subscription.Plan == 0 {
+		return nil, types.ErrorCanNotUpdateQuota
+	}
 	if msg.From != subscription.Owner {
 		return nil, types.ErrorUnauthorized
 	}

diff --git a/x/subscription/types/errors.go b/x/subscription/types/errors.go
@@ -28,5 +28,6 @@ var (
 	ErrorDuplicateQuota            = errors.Register(ModuleName, 211, "duplicate quota")
 	ErrorQuotaDoesNotExist         = errors.Register(ModuleName, 212, "quota does not exist")
 	ErrorCanNotAddQuota            = errors.Register(ModuleName, 213, "can not add quota")
-	ErrorCanNotCancel              = errors.Register(ModuleName, 214, "can not cancel")
+	ErrorCanNotUpdateQuota         = errors.Register(ModuleName, 214, "can not update quota")
+	ErrorCanNotCancel              = errors.Register(ModuleName, 215, "can not cancel")
 )