-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 4.2.0. #92
Add 4.2.0. #92
Conversation
@@ -30,6 +32,10 @@ dependencies: | |||
web_socket_channel: ^2.4.0 | |||
universal_io: ^2.2.0 | |||
async: ^2.10.0 | |||
isar: *isar_version | |||
isar_flutter_libs: *isar_version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After updating to 4.2.0 we get this issue:
isar/isar#1470
1: Task failed with an exception.
-----------
* What went wrong:
A problem occurred configuring project ':isar_flutter_libs'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
> Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.
If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OnestarLee @sf-tyler-jeong
isar version 3+ dependency does not work with Android Gradle Plugin 8.0+
We pinned our sendbird_chat_sdk to ">=4.1.2 <4.2.0" to be able to build project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asaarnak
Thank you for the information. If there is any update for isar regarding this, we will apply it.
Alternativiely, if you downgrade the gradle version to 7.x, is it okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sf-tyler-jeong
Should be ok on 7.x as this is 8+ only related breaking change.
We downgraded sendbird_chat_sdk instead as we have been using AGP 8+ over half a year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isar v4 supports AGP 8+ and also web, but it only has dev releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sf-tyler-jeong @OnestarLee Any plans to switch to isar-community fork?
We have locked to sendbird_chat_sdk: ">=4.1.2 <4.2.0"
dependency because of outdated isar
dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussions about isar
future: isar/isar#1498 isar/isar#1581
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asaarnak
I think we need to change it to isar-community
at an appropriate time.
Thanks for the information!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sf-tyler-jeong Any news when you plan to switch to maintained isar dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sf-tyler-jeong @OnestarLee Any news about fixing the isar version 3+ dependency does not work with Android Gradle Plugin 8.0+
issue?
No description provided.