Rainerteo patch 1 #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 19, 2017 09:55
add functions for changing application name, organization, organization domain and icon
correct accidental deletion of qmlbind_application_exit
|
Looks good, thanks! I'm investigating the travis fail in #44 , it's not related to your changes, it seems. Do you want to update |
| @@ -65,6 +65,35 @@ QMLBIND_API void qmlbind_application_release(qmlbind_application *self); | |||
| QMLBIND_API int qmlbind_application_exec(qmlbind_application *self); | |||
|
|
|||
| /*! | |||
| * \brief Sets the application's name. | |||
There was a problem hiding this comment.
You could add something this to the documentation, like you wrote in the pull request message:
This primarily allows for proper file names for saving and retrieving settings with the Settings QML Type
|
|
||
| /*! | ||
| * \brief Sets the application's organization name. | ||
| * |
There was a problem hiding this comment.
Same as setapplicationname
|
|
||
| /*! | ||
| * \brief Sets the application's organization domain. | ||
| * |
There was a problem hiding this comment.
Same as setapplicationname
|
This hasn't been merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functions for changing application name, organization, organization domain and icon
This primarily allows for proper file name selection for saving and retrieving settings (QSettings Class, Settings QML Type)
Adding an icon mostly allows proper display of running application in window selection bar of the window manager