Make Coretime async backing ready #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh it didn't go right... I'll try to fix it |
|
Yeah now it seems legit. |
seadanda
approved these changes
Mar 21, 2024
seadanda
merged commit 5abb10a
into
seadanda:donal-coretime-kusama
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you please merge this change into your Coretime branch before it is merged upstream? It prepares the Coretime runtime for async backing enablement and corresponds to polkadot-fellows#228. This would allow us to enable async backing for all the system parachains in a single release. I'm just concerned that if we go through the full procedure of first merging your Coretime PR and then creating a follow-up PR for the async backing, we'd either miss the release or delay it.