Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark dask #3319

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Benchmark dask #3319

wants to merge 5 commits into from

Conversation

mikelkou
Copy link

draft benchmarks with dask

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.26%. Comparing base (8e64165) to head (ca9b8f6).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3319      +/-   ##
==========================================
+ Coverage   77.22%   77.26%   +0.04%     
==========================================
  Files         111      111              
  Lines       12600    12630      +30     
==========================================
+ Hits         9730     9759      +29     
- Misses       2870     2871       +1     

see 11 files with indirect coverage changes

Copy link

scverse-benchmark bot commented Oct 25, 2024

Benchmark changes

Change Before [3d220a9] After [ca9b8f6] Ratio Benchmark (Parameter)
- 63.0±0.9ms 53.7±0.2ms 0.85 preprocessing_counts.FastSuite.time_calculate_qc_metrics('pbmc3k', 'counts')
- 60.4±0.5ms 46.4±1ms 0.77 preprocessing_counts.time_filter_cells('pbmc3k', 'counts')

Warning

Some benchmarks failed

Comparison: https://github.com/scverse/scanpy/compare/3d220a93c83fdd60ee3220c94db3dd8d5533c60d..ca9b8f671ae4403a89d775707498c7422e0384a3
Last changed: Thu, 7 Nov 2024 18:03:45 +0000

More details: https://github.com/scverse/scanpy/pull/3319/checks?check_run_id=32663197935

@flying-sheep flying-sheep linked an issue Nov 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmarks: Add all from Dask tutorial
2 participants