(fix): write out full PCA results when not run before neighbors #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilan-gold
added
Area - Topology 🍩
Open
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3079 +/- ##
=======================================
Coverage 75.85% 75.86%
=======================================
Files 110 110
Lines 12531 12532 +1
=======================================
+ Hits 9506 9507 +1
Misses 3025 3025
|
flying-sheep
approved these changes
May 31, 2024
flying-sheep
added a commit
that referenced
this pull request
Jun 3, 2024
Co-authored-by: Philipp A <[email protected]>
flying-sheep
pushed a commit
that referenced
this pull request
Jun 17, 2024
Co-authored-by: Philipp A <[email protected]> (cherry picked from commit 3d03f2e)
flying-sheep
added a commit
that referenced
this pull request
Jun 17, 2024
… (#3108) Co-authored-by: Philipp A <[email protected]> Co-authored-by: Ilan Gold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a better fix since we were already writing out
X_pca. The tests seem to pass andpcashould be idempotent so this really shouldn't break anything (hopefully).