Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if json is valid #580

Merged
merged 2 commits into from
Oct 4, 2020
Merged

Check if json is valid #580

merged 2 commits into from
Oct 4, 2020

Conversation

toml01
Copy link
Member

@toml01 toml01 commented Oct 4, 2020

Prevent cli from crashing when raw_input is not a valid json

@toml01 toml01 force-pushed the fix-cli-json-parsing-failure branch from 90fb564 to c2d2b58 Compare October 4, 2020 15:16
@reuvenpo reuvenpo merged commit ef6368f into dev/v1.0.x Oct 4, 2020
assafmo
assafmo reviewed Oct 5, 2020
View reviewed changes
Copy link
Member

@assafmo assafmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@toml01 toml01 deleted the fix-cli-json-parsing-failure branch October 6, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assafmo assafmo assafmo left review comments

@reuvenpo reuvenpo reuvenpo approved these changes

@Cashmaney Cashmaney Awaiting requested review from Cashmaney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toml01 @assafmo @reuvenpo