Docker build fixes #578
Merged
Docker build fixes #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuvenpo
requested review from
assafmo,
Cashmaney and
toml01
as code owners
reuvenpo
force-pushed
the
docker-build-fixes
branch
from
3fa1628 to
f8b3848
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit here changes a use of
git branch --show-currentwithgit rev-parse --abbrev-ref HEADbecause the former is not supported on git versions before 2.22 ([release notes]), while Ubuntu 18.04 LTS still offers 2.17.The second commit here adds keys to
base.Dockerfilewhich were missing when building for SW mode.