fix: make txhash in env uppercase #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transaction hashes are represented in the event logs as uppercase hexadecimal strings. To keep this consistent so that clients can expect all transaction hashes to be in the same format, the hash provided to contracts in the `env` struct should also be uppercase.
blake-regalia
requested review from
Cashmaney,
toml01,
liorbond and
valdok
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction hashes are represented in the event logs as uppercase hexadecimal strings. To keep this consistent so that clients can expect all transaction hashes to be in the same format, the hash provided to contracts in the
envstruct should also be uppercase.