fix(api): use overridden chainConfig in standardTraceBlockToFile
#871
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmountaintop
changed the title
standardTraceBlockToFile
0xmountaintop
changed the title
standardTraceBlockToFilestandardTraceBlockToFile
Thegaram
previously approved these changes
Jul 5, 2024
| @@ -769,7 +769,7 @@ func (api *API) standardTraceBlockToFile(ctx context.Context, block *types.Block | |||
| // Execute the transaction and flush any traces to disk | |||
| vmenv := vm.NewEVM(vmctx, txContext, statedb, chainConfig, vmConf) | |||
| statedb.SetTxContext(tx.Hash(), i) | |||
| l1DataFee, err := fees.CalculateL1DataFee(tx, statedb, api.backend.ChainConfig(), block.Number()) | |||
| l1DataFee, err := fees.CalculateL1DataFee(tx, statedb, chainConfig, block.Number()) | |||
There was a problem hiding this comment.
It looks like the only override that we might apply is BerlinBlock, is that intended?
There was a problem hiding this comment.
- that's the only one override i find in this file
- the override code (L733~734) is from 3-year-ago upstream, not made by us.
- in L770, the original code uses
chainConfig, but L772 is introduced by use and it's usingapi.backend.ChainConfig()
There was a problem hiding this comment.
Should we make it more generic? https://github.com/ethereum/go-ethereum/blob/master/eth/tracers/api.go#L761-L769 Or is that a lot of extra work?
There was a problem hiding this comment.
yes on "upstream" branch it's more generic, we can also update here on develop branch. I can update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
chainCfghas been overridden, we should use the overridden one.2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?