-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(permissionless batches): block production without signature #1087
base: jt/permissionless-batches-recovery
Are you sure you want to change the base?
feat(permissionless batches): block production without signature #1087
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…ty field in header
…ry' into jt/permissionless-batches-recovery-mine
@@ -562,7 +567,10 @@ func (s *Ethereum) Protocols() []p2p.Protocol { | |||
// Start implements node.Lifecycle, starting all internal goroutines needed by the | |||
// Ethereum protocol implementation. | |||
func (s *Ethereum) Start() error { | |||
eth.StartENRUpdater(s.blockchain, s.p2pServer.LocalNode()) | |||
// handler is not enabled when DA syncing enabled | |||
if !s.config.EnableDASyncing { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why disable when DA syncing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a nil pointer downstream when mining blocks without the networking layer being initialized
1. Purpose or design rationale of this PR
This PR enables creating blocks without a valid signature. This is necessary in permissionless mode for anyone to be able to produce blocks without having access to the latest valid key according to Clique consensus.
It is part of the permissionless batch production toolkit together with #1073 and scroll-tech/scroll#1555
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?