feat(txpool): only try demoting txns from accounts that were active #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
force-pushed
the
omerfirmak/txpool-reorg
branch
from
b57d606 to
b33eceb
Compare
jonastheis
previously approved these changes
Sep 20, 2024
Thegaram
reviewed
Sep 20, 2024
txpool demotes pending txns only if their nonce is now lower than the nonce in the latest state or the account no longer has enough funds to cover the costs. Unless the account in question was active since the last txpool reorg, there is no way that it's nonce changed or balance decreased.
omerfirmak
force-pushed
the
omerfirmak/txpool-reorg
branch
from
b33eceb to
3112cc1
Compare
omerfirmak
commented
Sep 23, 2024
| @@ -892,10 +889,6 @@ func (w *worker) commit() (common.Hash, error) { | |||
| } | |||
| } | |||
|
|
|||
| // A new block event will trigger a reorg in the txpool, pause reorgs to defer this until we fetch txns for next block. | |||
| // We may end up trying to process txns that we already included in the previous block, but they will all fail the nonce check | |||
| w.eth.TxPool().PauseReorgs() | |||
There was a problem hiding this comment.
removing as I don't think we will be needing this hack after this
colinlyguo
reviewed
Sep 23, 2024
colinlyguo
approved these changes
Sep 23, 2024
colinlyguo
reviewed
Sep 23, 2024
colinlyguo
previously approved these changes
Sep 23, 2024
georgehao
reviewed
Sep 23, 2024
georgehao
previously approved these changes
Sep 23, 2024
omerfirmak
dismissed stale reviews from georgehao and colinlyguo
via
5a750da
colinlyguo
approved these changes
Sep 24, 2024
georgehao
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
txpool demotes pending txns only if their nonce is now lower than the nonce in the latest state or the account no longer has enough funds to cover the costs. Unless the account in question was active since the last txpool reorg, there is no way that it's nonce changed or balance decreased.