Give Sprites Comment Attribute and allow comment duplication #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Victor-Crawshaw
force-pushed
the
develop
branch
from
5277d76 to
2080ee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves scratchfoundation/scratch-gui#3687
Proposed Changes
Create comment attribute in Sprite, and modify duplicate() method to copy over that comment attribute. Targets now take comments as an argument so that they may be copied over in Rendered Target as well.
Duplicate.Comments.Demo.mp4
Reason for Changes
Comments should be an attribute in Sprite because if comments want to be duplicated when sprites are duplicated, then it would make sense for them to be part of a sprite, rather than merely part of a target,
Test Coverage
Added unit tests in test/unit/sprites_rendered-target.js to ensure comments are duplicated along with a sprite, also made sure all other tests still pass.
