Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pen color range [0..99] #2274

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

helderman
Copy link

Attempted bugfix for "Pen Colors repeat each 101 numbers rather than each 100 numbers" as reported in the Scratch forum:
https://scratch.mit.edu/discuss/topic/369220/

Resolves

#2273

Proposed Changes

Apply modulo 100 on the pen color, instead of modulo 101.

Reason for Changes

Current behavior is confusing, inconsistent with Scratch 2.0, and (most likely) unintended.

Test Coverage

No test coverage yet. My apologies.

Attempted bugfix for "Pen Colors repeat each 101 numbers rather than each 100 numbers" as reported in the Scratch forum:
https://scratch.mit.edu/discuss/topic/369220/
@benjiwheeler
Copy link

I looked at this briefly and while I think there are deeper questions that #2273 raises that we should discuss, I think @helderman's fix is an improvement to the current situation.

@thisandagain thisandagain added this to the October 2019 milestone Sep 16, 2019
@BryceLTaylor BryceLTaylor modified the milestones: October 2019, Overdue Jul 13, 2020
@kchadha kchadha removed their assignment Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants