Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E16N: move extension manager from VM to Runtime #2243

Open
wants to merge 2 commits into
base: e16n
Choose a base branch
from
Open

E16N: move extension manager from VM to Runtime #2243

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8db8e46
move extensionManager from vm to runtime
Jul 25, 2019
ebe7186
add compatibility accessor for the Extension Manager
Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/virtual-machine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,14 @@ class VirtualMachine extends EventEmitter {
this.variableListener = this.variableListener.bind(this);
}

/**
* @returns {ExtensionManager} the extension manager, now owned by the runtime.
* @deprecated Please access the extension manager through the runtime instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also log this warning if it's accessed this way so we can find places we've missed in our own code. Although I wonder if we care/want that? Seems like accessing via VM from the outside could be seen as the right thing to do — the VM is the external interface. But internally we refer to the actual location?

*/
get extensionManager () {
return this.runtime.extensionManager;
}

/**
* Start running the VM - do this before anything else.
*/
Expand Down