Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated sprites lose their comments #3687

Open
apple502j opened this issue Nov 8, 2018 · 4 comments · May be fixed by scratchfoundation/scratch-vm#2502 or scratchfoundation/scratch-vm#5111
Open

Duplicated sprites lose their comments #3687

apple502j opened this issue Nov 8, 2018 · 4 comments · May be fixed by scratchfoundation/scratch-vm#2502 or scratchfoundation/scratch-vm#5111
Labels
bug help wanted needs triage
Milestone
Backlog

Comments

@apple502j
Copy link
Contributor

Thanks stmsmarty30 for finding this issue!

Expected Behavior

When duplicating sprites, comments should be kept

Actual Behavior

Sprites lose their comments

Steps to Reproduce

Add a comment on a sprite
Duplicate the sprite
The new sprite doesn't have a comment

Operating System and Browser

Windows 10 Firefox 63
@thisandagain thisandagain added this to the Backlog milestone Nov 28, 2018
@apple502j apple502j mentioned this issue Jun 29, 2020
Closed
@apple502j
Copy link
Contributor Author

can still repro - maybe PR soon

@apple502j
Copy link
Contributor Author

Looks like the easiest way to do this would probably be to move comment-related things to Sprite.

@apple502j apple502j linked a pull request Jun 30, 2020 that will close this issue
Open
@HeidiTao
Copy link

HeidiTao commented Nov 24, 2024 •
edited
Loading

@chrisgarrity We'd like to try looking into this as well! (@Victor-Crawshaw @John-Crawshaw @alx-zhu @sherryzhuge1)

This was referenced Dec 7, 2024
Closed
Open
@John-Crawshaw
Copy link

John-Crawshaw commented Dec 9, 2024 •
edited
Loading

Hey @chrisgarrity @BryceLTaylor , we've found a working solution for the comment duplication issue linked in PR scratchfoundation/scratch-vm#5111! Would appreciate if you took a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted needs triage
Projects
None yet
Milestone
Backlog
4 participants
@thisandagain @apple502j @HeidiTao @John-Crawshaw