Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping scripts in sprite/clone doesn't stop sounds that are playing "until done" #1410

Closed
TheLogFather opened this issue Aug 1, 2018 · 3 comments

Comments

@TheLogFather
Copy link

Expected Behavior

In Scratch 2.0, stopping the scripts of a sprite/clone will stop a sound that is currently being played by a scripts that's still running a "play sound until done" block.

Note this is also the case for a clone that gets deleted and is currently running a "play sound until done" block (since, in Scratch 2, its scripts get stopped when the clone is deleted).

Actual Behavior

In Scratch 3.0 the sounds continue playing even though the script running a "play sound until done" block has been terminated (either by "stop other scripts in sprite" or by deleting the clone).

Steps to Reproduce

Click on a "play sound until done" block (for a sound that lasts several seconds).
While the sound is playing, click on a "stop other scripts in sprite" block.

(Alternatively, have two "when I start as a clone" scripts. One of them starts the long sound playing 'until done', the other waits for a second or so and then deletes the clone. Then create a clone by clicking on a "create clone of myself" block...)

In Scratch 2 the sound will stop playing.
In Scratch 3 it won't stop playing.

Operating System and Browser

N/A

@TheLogFather
Copy link
Author

Forgot to reference #949, which is related (since its resolution led to this happening).

@BryceLTaylor
Copy link

This can be seen in this project:
As well as this one: 228613336

@Robomandude
Copy link

It should be noted that this issue also affects note blocks from the music extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants