Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain sounds continue after their clones are deleted #2803

Closed
Robomandude opened this issue Aug 6, 2018 · 3 comments
Closed

Certain sounds continue after their clones are deleted #2803

Robomandude opened this issue Aug 6, 2018 · 3 comments

Comments

@Robomandude
Copy link

Robomandude commented Aug 6, 2018

Expected Behavior

In scratch 2.0 if you delete a clone while it is busy executing a [play note for beats block], or a [play sound until finished] block, the sound cuts off.
This is useful for when you don't know in advance how long to play a note or if you don't want to play the entire sound.

It should be noted that [play sound] (now known as [start sound]) plays to completion regardless even in scratch 2.0

Actual Behavior

The sounds (and/or notes) continue to completion regardless of whether or not the clone is deleted partway through.

Steps to Reproduce

Create a script:
[When I start as clone]
[play note 60 for 10 beats]

Create another script:
[When I start as clone]
[rest for 2 beats]
[delete this clone]

Then create a clone.

Operating System and Browser

Windows 7
Google Chrome Version 67.0.3396.99 (Official Build) (64-bit)

@Robomandude
Copy link
Author

Oh a good use for this edge case behavior is demonstrated here: https://llk.github.io/scratch-gui/develop/compatibility-testing.html#237931636

@TheLogFather
Copy link

This is likely a dup of scratchfoundation/scratch-vm#1410 (though that mentions only sounds – the principle is the same, in that it's to do with Scratch 2 stopping sounds/notes playing in scripts that get terminated, and which Scratch 3 no longer does).

@thisandagain
Copy link
Contributor

Tracking in scratchfoundation/scratch-vm#1410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants