Skip to content

Commit

Permalink
Merge pull request #2400 from adroitwhiz/no-shadow-ops
Browse files Browse the repository at this point in the history
Remove BlockCached._shadowOps
  • Loading branch information
adroitwhiz authored May 12, 2020
2 parents f5ce73a + 3341489 commit 1ba3181
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions src/engine/execute.js
Original file line number Diff line number Diff line change
Expand Up @@ -267,13 +267,6 @@ class BlockCached {
*/
this._parentValues = null;

/**
* A sequence of shadow value operations that can be performed in any
* order and are easier to perform given that they are static.
* @type {Array<BlockCached>}
*/
this._shadowOps = [];

/**
* A sequence of non-shadow operations that can must be performed. This
* list recreates the order this block and its children are executed.
Expand Down Expand Up @@ -359,7 +352,6 @@ class BlockCached {
continue;
}

this._shadowOps.push(...inputCached._shadowOps);
this._ops.push(...inputCached._ops);
inputCached._parentKey = inputName;
inputCached._parentValues = this._argValues;
Expand All @@ -374,9 +366,7 @@ class BlockCached {

// The final operation is this block itself. At the top most block is a
// command block or a block that is being run as a monitor.
if (!this._isHat && this._isShadowBlock) {
this._shadowOps.push(this);
} else if (this._definedBlockFunction) {
if (this._definedBlockFunction) {
this._ops.push(this);
}
}
Expand Down

0 comments on commit 1ba3181

Please sign in to comment.