Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sb3_definitions): fix comment position validation #46

Merged

Conversation

kchadha
Copy link
Contributor

@kchadha kchadha commented Aug 13, 2018

A comment's x and y can be null. This will occur if a project is imported from 2.0, a sprite that is
not currently selected has comments, and that project is immediately saved in 3.0 without switching
to the other sprite that has comments.

A comment's x and y can be null. This will occur if a project is imported from 2.0, a sprite that is
not currently selected has comments, and that project is immediately saved in 3.0 without switching
to the other sprite that has comments.
@rschamp rschamp assigned kchadha and unassigned rschamp Aug 13, 2018
@kchadha kchadha merged commit 0f3a10d into scratchfoundation:master Aug 13, 2018
@kchadha kchadha deleted the fix-comment-position-validation branch August 13, 2018 20:00
@kchadha
Copy link
Contributor Author

kchadha commented Aug 13, 2018

🎉 This PR is included in version 4.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants