Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring dragging sprites to front #2712

Conversation

paulkaplan
Copy link
Contributor

@paulkaplan paulkaplan commented Jul 24, 2018

Resolves

What Github issue does this resolve (please include link)?

Resolves #1870

Implements outstanding feature to pop dragging sprites to the front of the renderer draw list permanently, not just while it is being dragged.

Proposed Changes

Describe what this Pull Request does

Use the target.goToFront to bring the sprite forward at the start of the drag. This works for both editor and player drag modes.

drag-mode

This solves the issue where in both player and editor mode, draggable sprites would not get popped to the front of the draw list.
@paulkaplan paulkaplan force-pushed the bring-dragging-sprites-to-front branch from 1e55a3f to 19dc033 Compare July 24, 2018 15:31
Copy link
Contributor

@kchadha kchadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@kchadha kchadha assigned paulkaplan and unassigned kchadha Jul 24, 2018
@paulkaplan paulkaplan merged commit 3b86377 into scratchfoundation:develop Jul 24, 2018
@paulkaplan paulkaplan deleted the bring-dragging-sprites-to-front branch July 24, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragging a sprite should move it to the front
2 participants