feat: support validating and installing provisioner files by uri #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Meier <[email protected]>
astromechza
force-pushed
the
uri-get-provisioner
branch
from
4a02575 to
52915fa
Compare
Signed-off-by: Ben Meier <[email protected]>
astromechza
requested review from
mathieu-benoit,
FL303,
chrishumanitec and
sujaya-sys
Signed-off-by: Ben Meier <[email protected]>
|
@mathieu-benoit good point, fixed up and added a test :) |
mathieu-benoit
requested changes
Sep 13, 2024
Signed-off-by: Ben Meier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing provisioners by copying yaml files around is not a great UX and makes things unecessarily multi-step.
This PR improves this by adding a
--provisioners <URI>flag which downloads a provisioner file using either http, git, or local filesystems and adds it into the .score-compose state directory at the top of the stack.