Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: more API related work #967

Merged
merged 4 commits into from
May 8, 2023
Merged

refactor: more API related work #967

merged 4 commits into from
May 8, 2023

Conversation

scop
Copy link
Owner

@scop scop commented May 8, 2023

This and that on the topic of API adjustments, see individual commits for details.

@scop scop force-pushed the refactor/api-work branch from 1844262 to fbc4353 Compare May 8, 2023 16:43
@scop
Copy link
Owner Author

scop commented May 8, 2023

Hm, something wrong with build dependencies it seems, the scp symlink is probably not there so the function is found. Not immediately clear to me what's wrong though.

Added some missing renamings in 1844262..fbc4353 but that's not the failure reason.

@scop scop force-pushed the refactor/api-work branch from fbc4353 to 007e641 Compare May 8, 2023 16:46
@scop
Copy link
Owner Author

scop commented May 8, 2023

Will merge without the scp change and file another PR for it.

@scop scop merged commit 8da5dfb into master May 8, 2023
@scop scop deleted the refactor/api-work branch May 8, 2023 16:48
@scop scop mentioned this pull request May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinomyoga akinomyoga akinomyoga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scop @akinomyoga