-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onMouseDown doesn't have the event parameter passed in correctly #88
Labels
Comments
@anandsainath nice find. Yea now that I'm looking, there's a few which don't explicitly pass the event as well. Will try my best to get a fix in for this soon. |
anandsainath
pushed a commit
to anandsainath/react-codemirror2
that referenced
this issue
May 24, 2018
@scniro I just created a pull request for the same. Can you take a look and check if its good? |
anandsainath
added a commit
to anandsainath/react-codemirror2
that referenced
this issue
May 25, 2018
scniro
added a commit
that referenced
this issue
May 26, 2018
Passing the event argument to callbacks that use it. #88
@anandsainath Fixed with 5.0.3. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is the current onMouseDown event that is bound.
The callback function doesn't have an event variable that is passed in - which causes ReferenceError: event is not defined in some browsers like Firefox.
The text was updated successfully, but these errors were encountered: