This repository has been archived by the owner on Dec 6, 2023. It is now read-only.
Relax assert for number of non-zero elements in test #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run 10 consecutive CI jobs for this PR - all were green:
https://github.com/scikit-learn-contrib/lightning/actions/runs/1624804596 |
mblondel
reviewed
Dec 28, 2021
| @@ -172,7 +174,10 @@ def test_debiasing_l1l2(): | |||
| max_iter=20, C=0.01, random_state=0) | |||
| clf.fit(mult_csc, mult_target) | |||
| assert clf.score(mult_csc, mult_target) > 0.75 | |||
| assert clf.n_nonzero(percentage=True) == 0.08 | |||
| if system() == "Windows": | |||
| assert 0.07 <= clf.n_nonzero(percentage=True) <= 0.1 | |||
There was a problem hiding this comment.
I would be fine with clf.n_nonzero(percentage=True) <= 0.1 without the platform-specific test.
There was a problem hiding this comment.
Thanks for your comment! Addressed in 4942a84. I also added lower bound into assertion to check that number is non-negative, if you don't mind.
StrikerRUS
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky test originally reported in #187 (comment).
I'm not limiting
ifbranch to 32-bit Windows because during preparing this PR I was observing the same test failures on 64-bit Windows as well: https://github.com/scikit-learn-contrib/lightning/runs/4637338353?check_suite_focus=true.