-
Notifications
You must be signed in to change notification settings - Fork 214
Conversation
requirements_build.txt
Outdated
@@ -1,2 +1,3 @@ | |||
cython | |||
setuptools<50.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that <
is probably not a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, looks it's unavoidable if you'd like to build scikit-learn from sources, unfortunately: numpy/numpy#20640 (comment).
By the way, y'all really should pin
setuptools
in your release branches. This is not done currently (https://github.com/scikit-learn/scikit-learn/blob/1.0.X/pyproject.toml#L4), and hence the breakage you're seeing in your CI will also occur when installing from an sdist withpip install scikit-learn
.
Anyway, we are going to have a big refactoring of the package building routine with Python 3.12 release according to scikit-learn/scikit-learn#21499.
scikit-learn 1.0.2 was released Dec 25, 2021. That release helps to make all our CI jobs green except Corresponding sources: Neither Should we also stop trying to build 32-bit Windows with new Python versions? Or is there any other ideas? |
83600b9
to
c5951e0
Compare
OK, I think this PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Building
scikit-learn
from sources doesn't work for Windows. There is along log
for the error.
Pining
setuptools
version as it was suggested in pypa/distutils#15 doesn't work (one more upstream issue: pypa/setuptools#2372). So let's just try to wait forscikit-learn
wheel for Python 3.10.