Skip to content

Commit

Permalink
[ios] Fix changes to BranchManager introduced in expo-branch commit
Browse files Browse the repository at this point in the history
In there we replaced `EXBranchManager` kernel service with two singleton modules
`EXBranchManager` used only in bare apps and `EXScopedBranchManager` used
in ExpoKit and in Expo client. Since kernel services are resolved based only on
`EX(\w+)`, we needed to either change `RNBranch` service requirement or implement
a better way of resolving kernel services. I settled on the former one.
  • Loading branch information
sjchmiela committed Aug 7, 2019
1 parent 7c4c686 commit c1dc64e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ @implementation ABI31_0_0RNBranch

@synthesize bridge = _bridge;

ABI31_0_0EX_EXPORT_SCOPED_MODULE(ABI31_0_0RNBranch, BranchManager);
ABI31_0_0EX_EXPORT_SCOPED_MODULE(ABI31_0_0RNBranch, ScopedBranchManager);

+ (Branch *)branch
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ @implementation ABI32_0_0RNBranch

@synthesize bridge = _bridge;

ABI32_0_0EX_EXPORT_SCOPED_MODULE(ABI32_0_0RNBranch, BranchManager);
ABI32_0_0EX_EXPORT_SCOPED_MODULE(ABI32_0_0RNBranch, ScopedBranchManager);

+ (Branch *)branch
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ @implementation ABI33_0_0RNBranch

@synthesize bridge = _bridge;

ABI33_0_0EX_EXPORT_SCOPED_MODULE(ABI33_0_0RNBranch, BranchManager);
ABI33_0_0EX_EXPORT_SCOPED_MODULE(ABI33_0_0RNBranch, ScopedBranchManager);

+ (Branch *)branch
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ @implementation ABI34_0_0RNBranch

@synthesize bridge = _bridge;

ABI34_0_0EX_EXPORT_SCOPED_MODULE(ABI34_0_0RNBranch, BranchManager);
ABI34_0_0EX_EXPORT_SCOPED_MODULE(ABI34_0_0RNBranch, ScopedBranchManager);

+ (Branch *)branch
{
Expand Down

0 comments on commit c1dc64e

Please sign in to comment.