Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): support more IP options in server creation #4219

Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Oct 23, 2024

No description provided.

@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Oct 23, 2024
@Codelax Codelax force-pushed the feat/instance-server-create-ip-options branch from e5e984a to 42e4c99 Compare October 23, 2024 11:12
@Codelax Codelax marked this pull request as ready for review October 23, 2024 11:13
@Codelax Codelax requested a review from remyleone as a code owner October 23, 2024 11:13
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.45205% with 15 lines in your changes missing coverage. Please review.

Project coverage is 70.90%. Comparing base (5bf53e0) to head (42e4c99).
Report is 304 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/instance/v1/custom_ip.go 62.50% 10 Missing and 2 partials ⚠️
...nal/namespaces/instance/v1/custom_server_create.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4219      +/-   ##
==========================================
- Coverage   75.45%   70.90%   -4.56%     
==========================================
  Files         202      294      +92     
  Lines       44323    65580   +21257     
==========================================
+ Hits        33444    46497   +13053     
- Misses       9653    17452    +7799     
- Partials     1226     1631     +405     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Oct 23, 2024
Merged via the queue into scaleway:master with commit 887452b Oct 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants