Restore v0.7.x fixture ordering #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We split up the suite-local fixture implementation into two fixtures, one of the `before*` methods, and one for the `after*` methods. Then we explicitly order `munitFixtures` to have the befores up front and the afters at the end.
valencik
commented
Dec 13, 2023
| @@ -34,7 +34,7 @@ class SuiteLocalFixtureSuite extends FunSuite { | |||
| } | |||
|
|
|||
| override def afterAll(): Unit = { | |||
| assertEquals(counter(), 17) | |||
| assertEquals(counter(), -10) | |||
There was a problem hiding this comment.
This is also reverting to it's previous value:
https://github.com/scalameta/munit/pull/430/files#diff-2ead4e24b5b9e268cfb99fcec413a0d9c860af4663e31761a3f2822dab593f39
This was referenced Dec 13, 2023
tgodzik
approved these changes
Dec 13, 2023
olafurpg
approved these changes
Dec 21, 2023
mzuehlke
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the ordering in which suite-local fixture
afterAllmethods are called.It implements the trick @olafurpg describes in #573 (comment) to restore the fixture ordering of v0.7.x
This ordering was changed in the first v1.0 milestone release
Therefore it is a breaking change within the v1.0 milestones in order to avoid a breaking change between v0.7.x and v1.0 overall.
Namely, we split up the suite-local fixture implementation into two fixtures, one of the
before*methods, and one for theafter*methods. Then we explicitly ordermunitFixturesto have the befores up front and the afters at the end.Of particular note, the tests/shared/src/main/scala/munit/FixtureOrderFrameworkSuite.scala file now looks the same as it did before https://github.com/scalameta/munit/pull/430/files?diff=split&w=0#diff-714f7ef13dfbbd4747770936315606f95d8aeba5f24890a45a4be216cda9d8a1
Note: The v0.7.x style ordering is not to run the
after*methods in opposite order to how thebefore*methods were run, making a mirror image like pattern. Instead it's more likeafter*methods run in the same order asbefore*methods except for suite-local fixtures which are special cased to run last.