Remove -release option from the Scala 3 PC

[tgodzik]

Previously, in a number of scenarios this option would break the presentation compiler for Scala 3. Now we filter it out since it's not important for the frontend phases.

[tanishiking]

LGTM

-release              Compile code with classes specific to the given version
                      of the Java platform available on the classpath and emit
                      bytecode for this version.

Indeed it's not important for frontend phases 👍

[tanishiking]

Why not

Suggested change

	private def removeDoubleOptions(options: List[String]): List[String] =
	options match
	case head :: _ :: tail if forbiddenDoubleOptions(head) =>
	removeDoubleOptions(tail)
	case head :: tail => head :: removeDoubleOptions(tail)
	case Nil => options
	options.filterNot(forbiddenDoubleOptions)

?

[tanishiking]

Ahh, nevermind, removeDoubleOptions transforms List("-release", "8", ...) to List(...)

[tgodzik]

I had to get a bit more creative here 😅

[kpodsiad]

Great!