Fix to module split-style to include packages for smallmodulesfor #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SmallModulesFor as it was implemented did not include the required list of packages needed for the linker configuration
I was trying to update the js-bridge in bloop-core and I noticed I had messed this up in the last PR... The smallest modules for option requires a list of packages, see: https://github.com/scala-js/scala-js/blob/61e8525eebef3b17290c900c84fea9ba91dc540e/linker-interface/shared/src/main/scala/org/scalajs/linker/interface/ModuleSplitStyle.scala#L43.
So, I'm not sure how you'd structure this ADT in Scala 2, but I think this is an ok solution.
something like this
prints
this seems like an reasonable encoding to me.