-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scala 3 support #101
Add Scala 3 support #101
Conversation
with CommonPublish | ||
with CommonPublish { | ||
|
||
// note: somehow, this doesn't work (causes "Please override mimaPreviousVersions or mimaPreviousArtifacts") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: I didn't spend too much time on it, hoping someone with more Mill experience can provide a better understanding and maybe a proper fix. This seems like something that only affects us until we publish the 3.x support.
@@ -0,0 +1,3 @@ | |||
package bloop.config | |||
|
|||
trait SourceGeneratorCompanionPlatform {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: extends AbstractFunction3
was causing a "missing apply method" in Scala 3. Adding that apply
was conflicting with the other apply
- hence, version-specific sources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We might want to switch to JDK 11 since jsoniter dropped support for JDK 8, which should not be an issue for the tools using bloop-config.
Also, looks like scalafix is not passing. We can disable it for Scala 3 if it proves to difficult to fix.
Tried just disabling def extraArgs = T {
if(scalaVersion() == scala3) List("---settings.OrganizeImports.removeUnused=false")
else Nil
}
override def fix(args: String*): Command[Unit] = T.command {
val allArgs = args ++ extraArgs()
super.fix(allArgs: _*)()
} but Mill complains:
which I don't really understand yet... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed now, should we do a release now?
Can't hurt 😅 |
It should be out! |
To unblock Bloop's ability to cross-build sbt-bloop for sbt 2.0 (sbt/sbt#7698).