Harden IDE: Cleanup trees after typechecking them in IDE #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this might involve forcing annotations.
smarter
approved these changes
Aug 16, 2017
| @@ -179,6 +179,16 @@ class InteractiveDriver(settings: List[String]) extends Driver { | |||
|
|
|||
| private val compiler: Compiler = new InteractiveCompiler | |||
|
|
|||
| private def cleanup(tree: tpd.Tree)(implicit ctx: Context): Unit = tree.foreachSubTree { t => | |||
There was a problem hiding this comment.
Add a documentation comment explaining why cleanup is necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided in the end it is simpler and more modular to sanitize trees in the IDE, after type checking them. That way we can separate concerns and need not burden the general tree handling.
Sanitization involves removing all attachments and symbol completers.