Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference, MiMa previous version and sync TASTy version #22187

Merged

Conversation

WojciechMazur
Copy link
Contributor

  • Update reference version to 3.6.3-RC1 (from 3.6.0)
  • Update mima previous binary verison to 3.6.2 (instead of unofficial 3.6.1)
  • Set TASTy version to 28.7-experimental-1 - it should have been set when branching of 3.6.3.
  • We now document better how and when tasty version should be set
  • Add additional runtime test to ensure we don't emit invalid TASTy version during Release / NIGHTLY releases and the expected version set in build matches version defined in TastyFormat - resolves Verify TASTy versions before releases #13447

Reference version and TASTy version bump needs to be performed at the same time (otherwise usage of compiler with stable TASTY would lead to failure in from-tasty non-bootstrapped tests)

[test_non_bootstrapped]


// Tested only in nightly / release builds
// Protects from publishing artifacts with incorrect TASTY version
@Test def testReleasedTastyVersion(): Unit = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test actually would be never executed - RELEASEBUILD and NIGHTLYBUILD are set only for the release but not in tests executed as a requirement to start releasing job

@WojciechMazur WojciechMazur merged commit 7441791 into scala:main Dec 11, 2024
29 checks passed
@WojciechMazur WojciechMazur deleted the build/update-reference-version branch December 11, 2024 16:55
@bishabosha
Copy link
Member

glad there's finally a real test :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify TASTy versions before releases
2 participants