Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit exposure to ConcurrentModificationException when sys props are replaced or mutated #22180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Limit exposure to ConcurrentModificationException when sys props are replaced or mutated #22180

wants to merge 2 commits into from

Conversation

jtjeferreira
Copy link
Contributor

@jtjeferreira
Copy link
Contributor Author

I think the build error is unrelated

[info] [republish] Fetching org.scala-lang:scala3-interfaces:3.6.4-RC1-bin-SNAPSHOT with coursier.jar...
[info] [republish] Fetching org.scala-lang:scala3-compiler_3:3.6.4-RC1-bin-SNAPSHOT with coursier.jar...
Resolution error: Error downloading org.scala-lang.modules:scala-asm:9.7.0-scala-2
  download error: Caught java.net.ConnectException (Connection timed out) while downloading https://repo1.maven.org/maven2/org/scala-lang/modules/scala-asm/9.7.0-scala-2/scala-asm-9.7.0-scala-2.pom
  not found: /__w/scala3/scala3/dist/linux-x86_64/target/streams/_global/republishAllResolved/_global/streams/localRepo/maven2/org/scala-lang/modules/scala-asm/9.7.0-scala-2/scala-asm-9.7.0-scala-2.pom
Error:  Error running coursier.jar with args fetch --no-default --repository central --repository file:///__w/scala3/scala3/dist/linux-x86_64/target/streams/_global/republishAllResolved/_global/streams/localRepo/maven2 org.scala-lang:scala3-compiler_3:3.6.4-RC1-bin-SNAPSHOT
Error:  (dist-linux-x86_64 / republishAllResolved) Error running coursier.jar with args fetch --no-default --repository central --repository file:///__w/scala3/scala3/dist/linux-x86_64/target/streams/_global/republishAllResolved/_global/streams/localRepo/maven2 org.scala-lang:scala3-compiler_3:3.6.4-RC1-bin-SNAPSHOT
Error:  Total time: 362 s (06:02), completed Dec 10, 2024, 12:40:45 PM
Error: Process completed with exit code 1.

jtjeferreira
jtjeferreira commented Dec 10, 2024
View reviewed changes
compiler/src/dotty/tools/dotc/config/PathResolver.scala
Comment on lines +56 to +57
//using propOrNone/getOrElse instead of propOrElse so that searchForBootClasspath is lazy evaluated
def javaBootClassPath: String = propOrNone("sun.boot.class.path") getOrElse searchForBootClasspath
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is a second commit, that is not part of the initial one that I was porting. But I think this improvement makes sense.

eed3si9n
eed3si9n approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtjeferreira Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.x] ConcurrentModificationException in SbtParser
2 participants
@jtjeferreira @eed3si9n