Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix provablyDisjoint handling enum constants with mixins #21876

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Fix provablyDisjoint handling enum constants with mixins #21876

merged 1 commit into from
Nov 2, 2024

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Nov 1, 2024

Fixes #21860

sjrd
sjrd approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ah, I was just looking at this one this morning, and had found the root issue but hadn't found a fix yet. LGTM

@dwijnand dwijnand marked this pull request as ready for review November 1, 2024 15:23
@sjrd sjrd merged commit 3e9b248 into scala:main Nov 2, 2024
29 checks passed
@dwijnand dwijnand deleted the fix-i21860-mixin-typetest branch November 4, 2024 10:44
@sjrd sjrd mentioned this pull request Nov 26, 2024
Closed
@WojciechMazur WojciechMazur added this to the 3.6.3 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.3
Development

Successfully merging this pull request may close these issues.

False-positive Unreachable case warning for mix-in type test
3 participants
@dwijnand @sjrd @WojciechMazur