Extract semanticDB for lifted definitions #21856
Merged
+76
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant LiftErased, make some lifting functions private if unused outside of class
natsukagami
commented
Oct 29, 2024
Comment on lines
-2889
to
-2890
| local0 => val local c$1: Int | ||
| local1 => val local b$1: Int @uncheckedVariance |
There was a problem hiding this comment.
These are lifted arguments from the recursive call in tests/semanticdb/expect/NamedApplyBlock.scala. Not sure if we want to include them in the symbols list?
There was a problem hiding this comment.
I would say no. Doesn't seem to be too useful.
tgodzik
approved these changes
Oct 30, 2024
KacperFKorban
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 20, 2024
KacperFKorban
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19970
Extract synthetic definitions in a lifted block.
We try to find blocks whose statements are all synthetic definitions, and
extract the rhs of all such definitions.
Add tests for occurences in lifting
Clean up EtaExpansion lifting functions