Do not consider uninhabited constructors when performing exhaustive match checking #21750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
reviewed
Oct 10, 2024
dwijnand
reviewed
Oct 10, 2024
Alex1005a
force-pushed
the
bottom-types-coverage-checking
branch
from
b61af65 to
d459140
Compare
|
I changed two tests because the compiler now correctly warns about the unreachable case. |
dwijnand
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During exhaustive match checking, you can suppress warnings for cases where a constructor contains a field of type Nothing, because it is impossible to obtain an instance of this
constructor. For example, Haskell and Ocaml do not issue a warning if the case of a constructor that has a field with typeVoidis not covered.