Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drop copied parent refinements before generating bytecode #21733

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

KacperFKorban
Copy link
Member

Refinements are copied over from parents, because they might be needed for tracked members that should have more specific types in the child. These members are generated without an implementation and should not be used in runtime.

possible fix for #21213

Refinements are copied over from parents, because they might be needed
for tracked members that should have more specific types in the child.
These members are generated without an implementation and should not be
used in runtime.
@KacperFKorban KacperFKorban requested a review from mbovel October 11, 2024 08:41
@KacperFKorban KacperFKorban marked this pull request as ready for review October 15, 2024 14:41
Copy link
Member

@mbovel mbovel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

For reference, addParentRefinements was introduced in 4894414.

@mbovel mbovel removed their assignment Oct 18, 2024
@KacperFKorban KacperFKorban merged commit 6d040c5 into scala:main Oct 18, 2024
28 checks passed
@KacperFKorban KacperFKorban deleted the fix-i21213 branch October 18, 2024 15:47
@WojciechMazur WojciechMazur added this to the 3.6.3 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants