Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define binary symbolic compiletime ops as infix #21683

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

smarter
Copy link
Member

@smarter smarter commented Oct 1, 2024

That way they get pretty-printed as infix in error messages.

That way they get pretty-printed as infix in error messages.
@smarter smarter requested a review from mbovel October 1, 2024 20:01
Copy link
Member

@mbovel mbovel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I believe this is a binary and source compatible change.

@smarter smarter merged commit 8244d67 into scala:main Oct 1, 2024
28 checks passed
@smarter smarter deleted the infix-ops branch October 1, 2024 20:48
@WojciechMazur WojciechMazur added this to the 3.6.0 milestone Oct 8, 2024
@prolativ
Copy link
Contributor

@smarter @mbovel What about TASTy-compatibility? I'm wondering if this change could/should be backported to LTS

@mbovel
Copy link
Member

mbovel commented Nov 15, 2024

I don't know.

But I don't see a strong need to backport this.

@prolativ
Copy link
Contributor

Ok, let's be conservative and not backport it then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants