Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Inkuire version to fix it for the new Scala versions #21611

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

KacperFKorban
Copy link
Member

It seems like Inkuire depended on the way some type lambdas were encoded in TASTy which caused it to falsely reject a ton of valid functions. This update also includes a slight change to the ordering heuristic, so that more complicated names of functions are shown lower in the lost and synthetic names are shown last.

Inkuire changes:

@KacperFKorban KacperFKorban marked this pull request as ready for review September 19, 2024 18:24
@KacperFKorban KacperFKorban merged commit 8068239 into scala:main Sep 20, 2024
28 checks passed
@KacperFKorban KacperFKorban deleted the bump-inkuire branch September 20, 2024 08:38
@WojciechMazur WojciechMazur added this to the 3.6.0 milestone Oct 8, 2024
WojciechMazur pushed a commit that referenced this pull request Dec 3, 2024
It seems like Inkuire depended on the way some type lambdas were encoded
in TASTy which caused it to falsely reject a ton of valid functions.
This update also includes a slight change to the ordering heuristic, so
that more complicated names of functions are shown lower in the lost and
synthetic names are shown last.

Inkuire changes:
- `1.0.0-M8` https://github.com/VirtusLab/Inkuire/releases/tag/v1.0.0-M8
- `1.0.0-M9` https://github.com/VirtusLab/Inkuire/releases/tag/v1.0.0-M9
[Cherry-picked 8068239]
WojciechMazur pushed a commit that referenced this pull request Dec 3, 2024
It seems like Inkuire depended on the way some type lambdas were encoded
in TASTy which caused it to falsely reject a ton of valid functions.
This update also includes a slight change to the ordering heuristic, so
that more complicated names of functions are shown lower in the lost and
synthetic names are shown last.

Inkuire changes:
- `1.0.0-M8` https://github.com/VirtusLab/Inkuire/releases/tag/v1.0.0-M8
- `1.0.0-M9` https://github.com/VirtusLab/Inkuire/releases/tag/v1.0.0-M9
[Cherry-picked 8068239]
WojciechMazur added a commit that referenced this pull request Dec 4, 2024
…to LTS (#22135)

Backports #21611 to the 3.3.5.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants