Simple performance improvement for Denotations #21584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
changed the title
|
Probably the question is why we don't cache signatures for provisional I add an assertion, but the signature never change even if the type is provisional. |
noti0na1
force-pushed
the
improve-denot
branch
from
7f9b452 to
d9e13e5
Compare
dwijnand
approved these changes
Sep 18, 2024
WojciechMazur
added a commit
that referenced
this pull request
Dec 4, 2024
) Backports #21584 to the 3.3.5. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple performance improvement extracted from #21278
This PR:
cachessignatureinSingleDenotationformatchDegree;denotcalls inwidens.This is a simpler approach which can reduce the compilation time of #20217 from 60s to about
20s40s.I revert the signature cache to keep this PR simple, because I don't understand why it works.